CPP-reviews
author Christian Urban <christian dot urban at kcl dot ac dot uk>
Sat, 14 Dec 2013 13:07:41 +1100
changeset 20 928c015eb03e
parent 15 baa2970a9687
permissions -rw-r--r--
updated slides
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
14
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     1
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     2
Dear Christian Urban,
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     3
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     4
   We are happy to inform you that you paper 42,
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     5
      A Formal Model and Correctness Proof for an Access Control Policy Framework
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     6
has been accepted for presentation at the third edition of the
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     7
International Conference on Certified Programs and Proofs.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     8
   Enclosed are the reviews for your paper. Please pay close attention to
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
     9
the comments of the reviewers in preparing the final version of your paper,
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    10
which will be due on Monday September 16, 2013.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    11
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    12
   Kind regards,
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    13
Georges Gonthier
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    14
Michael Norrish
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    15
   CPP 13 program chairs
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    16
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    17
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    18
----------------------- REVIEW 1 ---------------------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    19
PAPER: 42
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    20
TITLE: A Formal Model and Correctness Proof for an Access Control Policy Framework
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    21
AUTHORS: Chunhan Wu, Xingyuan Zhang and Christian Urban
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    22
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    23
OVERALL EVALUATION: 0 (borderline paper)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    24
REVIEWER'S CONFIDENCE: 4 (high)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    25
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    26
----------- REVIEW -----------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    27
This paper presents a formalisation of the Role-Compatibility access control model (RC-Model), which is similar to the Domain-Type Enforcement (DTE) model of SELinux, in Isabelle/HOL. The model is formalised with respect to an abstract operating system model with operations such as CreateFile, CloneProcess, WriteFile etc. Execution is modelled as sequences / traces of such events. Meaning is given to RC-Model policies by restricting the allowable traces of events to those permitted by the policy.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    28
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    29
Policies are further given meaning in terms of a notion of "taintedness" introduced by the authors. An initial set of /seeds/ are initially tainted; taint spreads out through the system (for instance from a process p to a file f when p writes to f etc.) as execution proceeds.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    30
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    31
Since the possible state space (sequences of allowed events) is infinite, the authors then devise a static, finite check to determine whether a particular entity can become tainted. This check effectively builds an abstraction (tainted^s) of the system in which all newly-created objects are aggregated together (which makes it finite), but records precise information regarding the taintedness of initial objects (which makes it precise for those objects).
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    32
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    33
The authors prove that their static check is both sound and complete (for undeletable objects).
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    34
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    35
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    36
The development appears technically sound. However, the ideas are fairly well understood from e.g. Paulson's work on the inductive model of security protocols, and from work devising finite, safe abstractions of access control systems, where the idea of aggregation for newly-created objects to produce finite, safe abstractions of systems is well applied.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    37
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    38
I would also argue that some of the claims in the motivation could be made more precise or backed-up with better evidence. For instance, the claim in the opening sentence -- which OSes exactly use RBAC? SELinux uses DTE which seems simpler than the RC-Model, but the authors never cite the DTE papers when mentioning SELinux. I assume that the similarity between DTE and RC-Model is the basis for the claim that the RC-Model is used to secure "Apache servers". This should be made clear.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    39
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    40
In general, I would suggest citing the SELinux papers, especially on the Domain-Type Enforcement model -- you certainly have space. Broader treatment of related work (e.g. on finite abstractions of dynamic access control systems by aggregation -- see e.g. Fred Spiessens' work on SCOLLAR) could also be accommodated in page limit I think.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    41
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    42
One other point is that the "tainted" notion seems to be presented mostly in terms of tracking the effects of a brek-in (see last paragraph of Section 4). However, it seems like it could equally well be used to reason about confidentiality in the absence of covert channels. This might deserve some discussion.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    43
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    44
Overall the work is solid, but isn't huge on novelty. Hence, my score of Borderline.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    45
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    46
Minor comments:
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    47
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    48
- Drop the word "randomly" in quotes from page 5. new process IDs need only be unique, no?
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    49
- Explain more explicitly that states are sequences of events; that paths are stored in reverse-order.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    50
- consider putting the "tained" relation into its own subsection, as this is new material over and above the straight RC-Model, right?
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    51
- On second-to-last line of page 10, drop "anchor of"
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    52
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    53
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    54
----------------------- REVIEW 2 ---------------------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    55
PAPER: 42
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    56
TITLE: A Formal Model and Correctness Proof for an Access Control Policy Framework
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    57
AUTHORS: Chunhan Wu, Xingyuan Zhang and Christian Urban
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    58
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    59
OVERALL EVALUATION: 2 (accept)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    60
REVIEWER'S CONFIDENCE: 4 (high)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    61
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    62
----------- REVIEW -----------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    63
This paper presents a formalization and correctness proof for the an access control policy framework called the Role-Compatibility Model. The paper introduces the dynamic semantics of a system controlled by an RC-model policy. It then develops a static check which is capable of determining all possible effects of a given RC-model policy on an initial system configuration. Finally, the paper proves the correctness of this check with respect to the dynamic semantics.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    64
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    65
In part, the paper is a case study of formalizing a recently introduced semi-formal system. However, the authors go beyond this by introducing a dynamic semantics which allows them to establish the correctness of the model they formalize. The contributions are interesting and relevant. I recommend the paper be accepted.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    66
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    67
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    68
----------------------- REVIEW 3 ---------------------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    69
PAPER: 42
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    70
TITLE: A Formal Model and Correctness Proof for an Access Control Policy Framework
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    71
AUTHORS: Chunhan Wu, Xingyuan Zhang and Christian Urban
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    72
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    73
OVERALL EVALUATION: -1 (weak reject)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    74
REVIEWER'S CONFIDENCE: 4 (high)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    75
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    76
----------- REVIEW -----------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    77
The paper formalizes the Role-Compatibility (RC) model of [4,5]. It defines its dynamic semantics, a notion of "taintability" (roughly the ability to influence a resource), and a more abstract semantics that is sound and complete for tainting. Both semantics consider only static, declarative policies, rather than e.g. actual executables and file contents. 
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    78
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    79
I am a bit surprised by the choice of RC as a starting point, inasmuch as there is a vast literature on RBAC, including more widely deployed systems, and papers using SMTs to check whether a policy excludes bad traces. Also, tainting is an important property, but many others are meant to be enforced by RBAC policies.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    80
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    81
The paper is well written, but its theorem is not very surprising, as the three main new definitions are closely aligned. Arguably, policies being complete is too much to hope for with real RBAC systems. Also, there is not much discussion of the formalization effort itself. 
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    82
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    83
Related work: "Gran: Model Checking Grsecurity RBAC Policies" at CSF 2012 explores similar issues with policies (but does not provide formal proofs); in particular it defines a property similar to tainting, develops an abstraction for dynamic taintability, and report issues with role inheritance rules.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    84
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    85
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    86
----------------------- REVIEW 4 ---------------------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    87
PAPER: 42
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    88
TITLE: A Formal Model and Correctness Proof for an Access Control Policy Framework
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    89
AUTHORS: Chunhan Wu, Xingyuan Zhang and Christian Urban
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    90
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    91
OVERALL EVALUATION: 2 (accept)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    92
REVIEWER'S CONFIDENCE: 3 (medium)
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    93
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    94
----------- REVIEW -----------
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    95
This is an appealing formalisation paper about an area with which I am not very familiar.  The background explanations are clear though, so I felt I was getting a good picture of what had been done, and its significance.  In essence, the paper describes an access-control formalism  due to Ott called the Role-Compatibility Model, develops an "obvious" mechanisation of that model, and then describes a nice decision procedure (original to this paper?) for checking the possible effects of corruption or tainting.  If one's security policy has been well-designed, then the d.p. will tell one that various forms of compromise can or can't affect permanent/important parts of the system.  So, for example, a compromised user account may well spread "compromise" or "taint" over a large proportion of the system (everything that user can touch), but should not be able to affect permanent files/resources owned by root (the contents of the /usr/bin directory, say).
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    96
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    97
I hesitate to rank the paper more strongly because of my own lack of confidence, but this seems like a strong contribution.  The formalisation of the RC model is elegantly done, but is perhaps fairly obvious given Paulson's well-known approach of characterising all possible system traces with an inductive relation.  However, adding to that contribution by inventing a finite abstraction of a system's dynamic behaviour, thereby creating a verified decision procedure for access control policy correctness, seems like something that certainly deserves to be published at CPP.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    98
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
    99
My only request for change would be for the authors to make it clearer whether or not their d.p. is original to them, and the degree of contribution they think it represents to the security community.
d43f46423298 added reviews from CPP
Christian Urban <christian dot urban at kcl dot ac dot uk>
parents:
diff changeset
   100